Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hailtop] Fix defaulting to hail.is when the user has no deploy-config #13585

Merged
merged 2 commits into from
Sep 7, 2023
Merged

[hailtop] Fix defaulting to hail.is when the user has no deploy-config #13585

merged 2 commits into from
Sep 7, 2023

Conversation

daniel-goldstein
Copy link
Contributor

@daniel-goldstein daniel-goldstein commented Sep 7, 2023 •
edited
Loading

or domain specified. The key bug here was a check for 'domain' not in config instead of config['domain'] is None

danking
danking previously requested changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@danking danking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daniel-goldstein can you just add the release change and change log to this PR?

@danking danking merged commit be9d88a into hail-is:main Sep 7, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danking danking danking approved these changes

Assignees

@danking danking

Labels
prio:high
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daniel-goldstein @danking